linux-kernel - Re: [PATCH 5.10 182/575] fscrypt: allow 256-bit master keys with AES-256-XTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211116115701.GA24252@amd>
Date:   Tue, 16 Nov 2021 12:57:01 +0100
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Paul Crowley <paulcrowley@...gle.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 182/575] fscrypt: allow 256-bit master keys with
 AES-256-XTS

Hi!

> From: Eric Biggers <ebiggers@...gle.com>
> 
> [ Upstream commit 7f595d6a6cdc336834552069a2e0a4f6d4756ddf ]
> 
> fscrypt currently requires a 512-bit master key when AES-256-XTS is
> used, since AES-256-XTS keys are 512-bit and fscrypt requires that the
> master key be at least as long any key that will be derived from it.

Quoting Eric Biggers <ebiggers@...nel.org>

I don't expect any problem with backporting this, but I don't see how
this
follows the stable kernel rules
(Documentation/process/stable-kernel-rules.rst).
I don't see what distinguishes this patch from ones that don't get
picked up by
AUTOSEL; it seems pretty arbitrary to me.

- Eric

And I agree, this should not be in stable.

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)