linux-kernel - Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Nov 2021 18:01:42 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Zameer Manji <zmanji@...il.com>, gregkh@...uxfoundation.org,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

On 11/16/21 17:18, Dan Carpenter wrote:
>> I cannot ack, since I am not the maintainer (or even reviewer) of this
>> driver :) I just saw this BIT() definition and decided to say, that it can
>> be also removed
> 
> Just give a Reviewed-by tag...  No one is appointed as a maintainer, you
> just have to start handing our reviewed-by tags until people start to
> respect your judgement and then you're a maintainer.
> 

Ok, I will send the R-b tag, since patch looks correct to me as is :)

I think, I misunderstood what "ack" means. I thought Zameer means 
Acked-by tag, which can sent only by maintainers (Larry and Phillip in 
case of r8188eu), but I was wrong, I guess...





With regards,
Pavel Skripkin