linux-kernel - Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211116151139.GJ26989@kadam>
Date:   Tue, 16 Nov 2021 18:11:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Zameer Manji <zmanji@...il.com>, gregkh@...uxfoundation.org,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

On Tue, Nov 16, 2021 at 06:01:42PM +0300, Pavel Skripkin wrote:
> On 11/16/21 17:18, Dan Carpenter wrote:
> > > I cannot ack, since I am not the maintainer (or even reviewer) of this
> > > driver :) I just saw this BIT() definition and decided to say, that it can
> > > be also removed
> > 
> > Just give a Reviewed-by tag...  No one is appointed as a maintainer, you
> > just have to start handing our reviewed-by tags until people start to
> > respect your judgement and then you're a maintainer.
> > 
> 
> Ok, I will send the R-b tag, since patch looks correct to me as is :)
> 
> I think, I misunderstood what "ack" means. I thought Zameer means Acked-by
> tag, which can sent only by maintainers (Larry and Phillip in case of
> r8188eu), but I was wrong, I guess...

To me Acked by means you approve the patch so it's like, yeah, normally
maintainers use it.  But sometimes like people ask for your opinion and
then you can Ack it.  Or maybe you just want to express joy about a
feature.  (Please feel joy very sparingly. :P).

regards,
dan carpenter