linux-kernel - Re: [PATCH v2 7/8] crypto: stm32/cryp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2111161614500.27385@gnbcxd0088.gnb.st.com>
Date:   Tue, 16 Nov 2021 16:20:28 +0100
From:   Nicolas Toromanoff <nicolas.toromanoff@...s.st.com>
To:     Nicolas Toromanoff <nicolas.toromanoff@...s.st.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Marek Vasut <marex@...x.de>, Ard Biesheuvel <ardb@...nel.org>,
        <linux-crypto@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 7/8] crypto: stm32/cryp - fix bugs and crash in
 tests


Hello,

> +static void stm32_cryp_write_ccm_first_header(struct stm32_cryp *cryp)
> +{
> [...]
> +	} else {
> +		/* Build the two first u32 of B1 */
> +		b8[0] = 0xFF;
> +		b8[1] = 0xFE;
> +		b8[2] = alen & 0xFF000000 >> 24;
> +		b8[3] = alen & 0x00FF0000 >> 16;
> +		b8[4] = alen & 0x0000FF00 >> 8;

Smatch found a bug here: "warn: shift has higher precedence than mask"

Regards,
Nicolas.