linux-kernel - Re: [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZPfJtkvo3bsfaCg@sirena.org.uk>
Date:   Tue, 16 Nov 2021 16:41:10 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Doug Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma

On Tue, Nov 16, 2021 at 09:27:59PM +0530, Vinod Koul wrote:
> On 03-11-21, 14:17, Doug Anderson wrote:

> > if (result->residue) {
> >   dev_err(...);
> >   return;
> > }
> > spi_finalize_current_transfer(...);

> Should we always call spi_finalize_current_transfer() ? This way we
> timeout... What is the way to signal error has occurred..?

Yes, set an error in the transfer and then finalize it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)