linux-kernel - Re: [PATCH v2 3/3] power: supply: max77976: add Maxim MAX77976 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f91e875-3a87-0b01-4b40-232ca109ef38@lucaceresoli.net>
Date:   Tue, 16 Nov 2021 18:35:55 +0100
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v2 3/3] power: supply: max77976: add Maxim MAX77976
 charger driver

Hi Sebastian,

On 16/11/21 16:21, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Nov 08, 2021 at 05:27:06PM +0100, Luca Ceresoli wrote:
>> Add support for the MAX77976 3.5/5.5A 1-Cell Li+ Battery Charger.
>>
>> This is a simple implementation enough to be used as a simple battery
>> charger without OTG and boost.
>>
>> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>>
>> ---
> 
> Thanks, I queued this to power-supply's for-next branch together
> with the other 2 patches

Thanks!

> with one small change: The of_match_ptr()
> is not needed and actually should result in a warning when building
> the driver with CONFIG_OF disabled.

Ouch. I made the same mistake in the past and the kernel test robot
noticed, I wonder why it didn't this time but hopefully I will remember
in the future!

Regards,
-- 
Luca