linux-kernel - Re: [PATCH] RDMA/bnxt_re: Scan the whole bitmap when checking if "disabling RCFW with pending cmd-bit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211116175724.GC2661511@nvidia.com>
Date:   Tue, 16 Nov 2021 13:57:24 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     selvin.xavier@...adcom.com, dledford@...hat.com,
        sriharsha.basavapatna@...adcom.com, eddie.wai@...adcom.com,
        somnath.kotur@...adcom.com, leon@...nel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] RDMA/bnxt_re: Scan the whole bitmap when checking if
 "disabling RCFW with pending cmd-bit"

On Fri, Nov 12, 2021 at 09:59:04AM +0100, Christophe JAILLET wrote:
> The 'cmdq->cmdq_bitmap' bitmap is 'rcfw->cmdq_depth' bits long.
> The size stored in 'cmdq->bmap_size' is the size of the bitmap in bytes.
> 
> Remove this erroneous 'bmap_size' and use 'rcfw->cmdq_depth' directly in
> 'bnxt_qplib_disable_rcfw_channel()'. Otherwise some error messages may
> be missing.
> 
> Other uses of 'cmdq_bitmap' already take into account 'rcfw->cmdq_depth'
> directly.
> 
> Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Acked-by: Selvin Xavier <selvin.xavier@...adcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 6 ++----
>  drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 1 -
>  2 files changed, 2 insertions(+), 5 deletions(-)

Applied to for-next, thanks

Jason