linux-kernel - Re: [PATCH] tty: serial: jsm_tty: fixed a assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 19:42:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sahil Patidar <sahilpatidar4051@...il.com>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial:  jsm_tty: fixed a assignment in if condition

On Mon, Nov 15, 2021 at 11:54:13PM +0530, Sahil Patidar wrote:
> Fixed assignment in if condition.

What exactly is "fixed"?

And why are there two spaces in your subject line?

> 
> Signed-off-by: Sahil Patidar <sahilpatidar4051@...il.com>
> ---
>  drivers/tty/serial/jsm/jsm_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
> index d74cbbbf33c6..44507b1ff93a 100644
> --- a/drivers/tty/serial/jsm/jsm_tty.c
> +++ b/drivers/tty/serial/jsm/jsm_tty.c
> @@ -746,10 +746,10 @@ static void jsm_carrier(struct jsm_channel *ch)
>  void jsm_check_queue_flow_control(struct jsm_channel *ch)
>  {
>  	struct board_ops *bd_ops = ch->ch_bd->bd_ops;
> -	int qleft;
> +	int qleft = ch->ch_r_tail - ch->ch_r_head - 1;
>  
>  	/* Store how much space we have left in the queue */
> -	if ((qleft = ch->ch_r_tail - ch->ch_r_head - 1) < 0)
> +	if (qleft < 0)

What was wrong with the original code that required this change?

thanks,

greg k-h