[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YZKiJFpSU8kIK6Tq@kroah.com>
Date: Mon, 15 Nov 2021 19:08:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>
Cc: linux-kernel@...r.kernel.org, jic23@...nel.org, lars@...afoo.de,
linux-iio@...r.kernel.org, git@...inx.com, michal.simek@...inx.com,
rafael@...nel.org, linux-acpi@...r.kernel.org,
andriy.shevchenko@...ux.intel.com, heikki.krogerus@...ux.intel.com
Subject: Re: [PATCH] device property: Add fwnode_iomap()
On Mon, Nov 15, 2021 at 05:38:19PM +0000, Anand Ashok Dumbre wrote:
> This patch introduces a new helper routine - fwnode_iomap(),
> which allows to map the memory mapped IO for a given device node.
>
> Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>
> ---
> drivers/base/property.c | 15 +++++++++++++++
> include/linux/property.h | 2 ++
> 2 files changed, 17 insertions(+)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 453918eb7390..9323e9b5de02 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -1021,6 +1021,21 @@ int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
> }
> EXPORT_SYMBOL(fwnode_irq_get);
>
> +/**
> + * fwnode_iomap - Maps the memory mapped IO for a given fwnode
> + * @fwnode: Pointer to the firmware node
> + * @index: Index of the IO range
> + *
> + * Returns a pointer to the mapped memory.
> + */
> +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index) {
> + if (is_of_node(fwnode))
> + return of_iomap(to_of_node(fwnode), index);
> +
> + return NULL;
> +}
> +EXPORT_SYMBOL(fwnode_iomap);
> +
> /**
> * fwnode_graph_get_next_endpoint - Get next endpoint firmware node
> * @fwnode: Pointer to the parent firmware node
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 357513a977e5..9bb0b0155402 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -121,6 +121,8 @@ void fwnode_handle_put(struct fwnode_handle *fwnode);
>
> int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
>
> +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index);
> +
> unsigned int device_get_child_node_count(struct device *dev);
>
> static inline bool device_property_read_bool(struct device *dev,
> --
> 2.17.1
>
Also, always run scripts/checkpatch.pl before sending patches out so you
do not get grumpy maintainers telling you to run scripts/checkpatch.pl
on your patches :)
thanks,
greg k-h
Powered by blists - more mailing lists