linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i_hc8=uX_y=1z+FvOWR1-eZVbUAGf3VQ15k+gEcOrVpQ@mail.gmail.com>
Date:   Wed, 17 Nov 2021 20:12:05 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Adamos Ttofari <attofari@...zon.de>
Cc:     Hendrik Borghorst <hborghor@...zon.de>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Giovanni Gherdovich <ggherdovich@...e.cz>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Add Ice Lake server to out-of-band IDs

On Fri, Nov 12, 2021 at 10:17 AM Adamos Ttofari <attofari@...zon.de> wrote:
>
> Commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in
> no-HWP mode") enabled the use of Intel P-State driver for Ice Lake servers.
> But it doesn't cover the case when OS can't control P-States.
>
> Therefore, for Ice Lake server, if MSR_MISC_PWR_MGMT bits 8 or 18 are
> enabled, then the Intel P-State driver should exit as OS can't control
> P-States.
>
> Fixes: fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode")
>
> Signed-off-by: Adamos Ttofari <attofari@...zon.de>
> Cc: Hendrik Borghorst <hborghor@...zon.de>
> Cc: David Woodhouse <dwmw@...zon.co.uk>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 815df3daae9d..1088ff350159 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2353,6 +2353,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst = {
>         X86_MATCH(BROADWELL_D,          core_funcs),
>         X86_MATCH(BROADWELL_X,          core_funcs),
>         X86_MATCH(SKYLAKE_X,            core_funcs),
> +       X86_MATCH(ICELAKE_X,            core_funcs),
>         {}
>  };
>
> --

Applied as 5.16-rc material, thanks!