linux-kernel - Re: [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a15db099-a83f-69bd-2cbb-420055087904@gmail.com>
Date:   Wed, 17 Nov 2021 12:34:41 -0700
From:   David Ahern <dsahern@...il.com>
To:     Yajun Deng <yajun.deng@...ux.dev>, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4,
 6}_confirm_neigh

On 11/17/21 5:02 AM, Yajun Deng wrote:
> -		unsigned long now = jiffies;
> -
> -		/* avoid dirtying neighbour */
> -		if (READ_ONCE(n->confirmed) != now)
> -			WRITE_ONCE(n->confirmed, now);

Just move this part to neigh_confirm and leave the rest as it is. That
READ_ONCE, WRITE_ONCE pair exists in other places that could use the
neigh_confirm style helper.