lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202111180401.v0fCdzUF-lkp@intel.com>
Date:   Thu, 18 Nov 2021 04:29:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rob Clark <robdclark@...omium.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Dave Airlie <airlied@...hat.com>
Subject: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1148:33: warning:
 variable 'priv' set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ee1703cda8dc777e937dec172da55beaf1a74919
commit: de99e6479885dfa3f64a9511a6477c2b7899e53f Merge tag 'drm-msm-next-2021-10-26' of https://gitlab.freedesktop.org/drm/msm into drm-next
date:   3 weeks ago
config: arm-randconfig-r005-20211116 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=de99e6479885dfa3f64a9511a6477c2b7899e53f
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout de99e6479885dfa3f64a9511a6477c2b7899e53f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function 'dpu_encoder_virt_enable':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1148:33: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
    1148 |         struct msm_drm_private *priv;
         |                                 ^~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function 'dpu_encoder_virt_disable':
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1197:33: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
    1197 |         struct msm_drm_private *priv;
         |                                 ^~~~


vim +/priv +1148 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1143  
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1144  static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1145  {
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1146  	struct dpu_encoder_virt *dpu_enc = NULL;
86b89080368b469 Jeykumar Sankaran 2018-09-05  1147  	int ret = 0;
c943b4948b5848f Chandan Uddaraju  2020-08-27 @1148  	struct msm_drm_private *priv;
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1149  	struct drm_display_mode *cur_mode = NULL;
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1150  
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1151  	if (!drm_enc) {
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1152  		DPU_ERROR("invalid encoder\n");
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1153  		return;
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1154  	}
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1155  	dpu_enc = to_dpu_encoder_virt(drm_enc);
fba7427eb594964 Sean Paul         2018-11-16  1156  
fba7427eb594964 Sean Paul         2018-11-16  1157  	mutex_lock(&dpu_enc->enc_lock);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1158  	cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
c943b4948b5848f Chandan Uddaraju  2020-08-27  1159  	priv = drm_enc->dev->dev_private;
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1160  
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1161  	trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1162  			     cur_mode->vdisplay);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1163  
86b89080368b469 Jeykumar Sankaran 2018-09-05  1164  	/* always enable slave encoder before master */
86b89080368b469 Jeykumar Sankaran 2018-09-05  1165  	if (dpu_enc->cur_slave && dpu_enc->cur_slave->ops.enable)
86b89080368b469 Jeykumar Sankaran 2018-09-05  1166  		dpu_enc->cur_slave->ops.enable(dpu_enc->cur_slave);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1167  
86b89080368b469 Jeykumar Sankaran 2018-09-05  1168  	if (dpu_enc->cur_master && dpu_enc->cur_master->ops.enable)
86b89080368b469 Jeykumar Sankaran 2018-09-05  1169  		dpu_enc->cur_master->ops.enable(dpu_enc->cur_master);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1170  
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1171  	ret = dpu_encoder_resource_control(drm_enc, DPU_ENC_RC_EVENT_KICKOFF);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1172  	if (ret) {
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1173  		DPU_ERROR_ENC(dpu_enc, "dpu resource control failed: %d\n",
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1174  				ret);
fba7427eb594964 Sean Paul         2018-11-16  1175  		goto out;
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1176  	}
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1177  
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1178  	_dpu_encoder_virt_enable_helper(drm_enc);
fba7427eb594964 Sean Paul         2018-11-16  1179  
167dac97eb46c7b Bjorn Andersson   2021-10-16  1180  	if (drm_enc->encoder_type == DRM_MODE_ENCODER_TMDS) {
167dac97eb46c7b Bjorn Andersson   2021-10-16  1181  		ret = msm_dp_display_enable(dpu_enc->dp, drm_enc);
c943b4948b5848f Chandan Uddaraju  2020-08-27  1182  		if (ret) {
c943b4948b5848f Chandan Uddaraju  2020-08-27  1183  			DPU_ERROR_ENC(dpu_enc, "dp display enable failed: %d\n",
c943b4948b5848f Chandan Uddaraju  2020-08-27  1184  				ret);
c943b4948b5848f Chandan Uddaraju  2020-08-27  1185  			goto out;
c943b4948b5848f Chandan Uddaraju  2020-08-27  1186  		}
c943b4948b5848f Chandan Uddaraju  2020-08-27  1187  	}
fba7427eb594964 Sean Paul         2018-11-16  1188  	dpu_enc->enabled = true;
fba7427eb594964 Sean Paul         2018-11-16  1189  
fba7427eb594964 Sean Paul         2018-11-16  1190  out:
fba7427eb594964 Sean Paul         2018-11-16  1191  	mutex_unlock(&dpu_enc->enc_lock);
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1192  }
25fdd5933e4c0f5 Jeykumar Sankaran 2018-06-27  1193  

:::::: The code at line 1148 was first introduced by commit
:::::: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add displayPort driver support

:::::: TO: Chandan Uddaraju <chandanu@...eaurora.org>
:::::: CC: Rob Clark <robdclark@...omium.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32579 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ