lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <74100d46dc362cccaca5ce6b780dfa3d99fd96df.camel@intel.com>
Date:   Wed, 17 Nov 2021 23:25:35 +0000
From:   "Winiarska, Iwona" <iwona.winiarska@...el.com>
To:     "zweiss@...inix.com" <zweiss@...inix.com>
CC:     "corbet@....net" <corbet@....net>,
        "jae.hyun.yoo@...ux.intel.com" <jae.hyun.yoo@...ux.intel.com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "andrew@...id.au" <andrew@...id.au>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "olof@...om.net" <olof@...om.net>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "d.mueller@...oft.ch" <d.mueller@...oft.ch>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "joel@....id.au" <joel@....id.au>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>, "bp@...en8.de" <bp@...en8.de>
Subject: Re: [PATCH v3 00/13] Introduce PECI subsystem

On Wed, 2021-11-17 at 03:56 +0000, Zev Weiss wrote:
> On Mon, Nov 15, 2021 at 10:25:39AM PST, Iwona Winiarska wrote:
> > Hi,
> > 
> > This is a third round of patches introducing PECI subsystem.
> > Sorry for the delay between v2 and v3.
> > 
> 
> Hi Iwona,
> 
> I've done some testing of these patches on my AST2500/E-2778G OpenBMC
> platform -- I had to do a small bit of hacking to add support for
> INTEL_FAM6_KABYLAKE, but with that in place the newly-added code for the
> 8.8 format seems to work as it should.  Thanks!

Thanks for the report and testing :)

> 
> In poking at it a bit further I encountered some sub-optimal behavior
> w.r.t. to host power state transitions and timeouts though --
> essentially, if I ever hit a timeout in aspeed_peci_xfer() (for example
> on a read of a hwmon tempX_input file after an unexpected host
> shutdown), it seems to get stuck in a state where even if the host comes
> back online, all attempted PECI transfers continue just timing out.
> (Rebooting the BMC seems to resolve the problem.)  This also happens if
> I remove the peci client device via the 'remove' sysfs file, shut down
> the host, and then do a rescan via sysfs while the host is off (i.e.
> another operation that times out).
> 
> Let me know if there's any other info that would be helpful for
> debugging.

That's unexpected. I do have an idea what might have caused that. Let me fix it
in v4.

Thanks
-Iwona

> 
> 
> Thanks,
> Zev

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ