linux-kernel - Re: [PATCH] tracing: fix va_list breakage in trace_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211117184138.3bc7156e@gandalf.local.home>
Date:   Wed, 17 Nov 2021 18:41:38 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Nikita Yushchenko <nikita.yushchenko@...tuozzo.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        kernel@...nvz.org
Subject: Re: [PATCH] tracing: fix va_list breakage in trace_check_vprintf()

On Wed, 17 Nov 2021 18:38:27 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> The real fix is:
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index f9139dc1262c..7aa5ea5ca912 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3654,6 +3654,10 @@ static bool trace_safe_str(struct trace_iterator *iter, const char *str)
>  	struct trace_event *trace_event;
>  	struct trace_event_call *event;
>  
> +	/* if seq is full, then we can't test it */
> +	if (iter->seq->full)
> +		return true;
> +
>  	/* OK if part of the event data */
>  	if ((addr >= (unsigned long)iter->ent) &&
>  	    (addr < (unsigned long)iter->ent + iter->ent_size))

BTW, feel free to respin the patch and send a v2 and just add:

Suggested-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve