linux-kernel - RE: [PATCH v8 3/3] remoteproc: qcom: q6v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 12:01:51 +0530
From:   "Rakesh Pillai" <pillair@...eaurora.org>
To:     "'Stephen Boyd'" <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <mathieu.poirier@...aro.org>,
        <ohad@...ery.com>, <p.zabel@...gutronix.de>, <robh+dt@...nel.org>
Cc:     <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <sibis@...eaurora.org>,
        <mpubbise@...eaurora.org>, <kuabhs@...omium.org>
Subject: RE: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS



> -----Original Message-----
> From: Stephen Boyd <swboyd@...omium.org>
> Sent: Wednesday, November 17, 2021 4:25 AM
> To: Rakesh Pillai <pillair@...eaurora.org>; agross@...nel.org;
> bjorn.andersson@...aro.org; mathieu.poirier@...aro.org; ohad@...ery.com;
> p.zabel@...gutronix.de; robh+dt@...nel.org
> Cc: linux-arm-msm@...r.kernel.org; linux-remoteproc@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> sibis@...eaurora.org; mpubbise@...eaurora.org; kuabhs@...omium.org
> Subject: Re: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for
> sc7280 WPSS
> 
> Quoting Rakesh Pillai (2021-11-02 06:44:33)
> > @@ -457,7 +608,13 @@ static int adsp_probe(struct platform_device
> *pdev)
> >         if (ret)
> >                 goto free_rproc;
> >
> > -       pm_runtime_enable(adsp->dev);
> > +       ret = qcom_rproc_pds_attach(adsp->dev, adsp->proxy_pds,
> > +                                   desc->proxy_pd_names);
> > +       if (ret < 0) {
> > +               dev_err(&pdev->dev, "Failed to attach proxy power domains\n");
> > +               goto free_rproc;
> > +       }
> > +       adsp->proxy_pd_count = ret;
> 
> Can we check this against the define so that we don't have more than the
> fixed number of power domains and try to access elements beyond the
> length of the array?

The number of entries populated in the "proxy_pds" array depends on the "desc->proxy_pd_names", which is statically
initialized for each remoteproc. Hence there will not be any out of bound access for this array.

Thanks,
Rakesh Pillai.