linux-kernel - Re: [PATCH 1/3] serial: liteuart: fix compile testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZTGJzJcQ3oIEsGy@hovoldconsulting.com>
Date:   Wed, 17 Nov 2021 10:06:47 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilia Sergachev <silia@...z.ch>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        Filip Kokosinski <fkokosinski@...micro.com>,
        Stafford Horne <shorne@...il.com>
Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing

On Tue, Nov 16, 2021 at 05:44:14PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold <johan@...nel.org> wrote:
> >
> > Allow the liteuart driver to be compile tested by fixing the broken
> > Kconfig dependencies.
> 
> ...
> 
> >  config SERIAL_LITEUART
> >         tristate "LiteUART serial port support"
> > +       depends on LITEX || COMPILE_TEST
> >         depends on HAS_IOMEM
> > -       depends on OF || COMPILE_TEST
> > -       depends on LITEX
> 
> > +       depends on OF
> 
> AFAICS this is optional and prevents compile testing in some cases.

Yeah, you're right; that clause should stay. I'll send a v2. Thanks.

> >         select SERIAL_CORE
> >         help
> >           This driver is for the FPGA-based LiteUART serial controller from LiteX

Johan