linux-kernel - Re: [PATCH v2 0/3] serial: liteuart: fix driver unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve9MB4MW9KDPoNhnPa8TCabmMgLbt6H7qrGgwmA8CpdNg@mail.gmail.com>
Date:   Wed, 17 Nov 2021 12:42:53 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ilia Sergachev <silia@...z.ch>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Stafford Horne <shorne@...il.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] serial: liteuart: fix driver unbind

On Wed, Nov 17, 2021 at 12:05 PM Johan Hovold <johan@...nel.org> wrote:
>
> Ilia Sergachev noted that the liteuart remove() function would trigger a
> NULL-pointer dereference if it was ever called since the driver data
> pointer was never initialised.
>
> Turns out there are more bugs in this part of the driver which clearly
> has never been tested.
>
> Also relax the Kconfig dependencies so that the driver can be
> compile-tested without first enabling a seemingly unrelated SoC
> controller driver.
>
> Note that this series depends on the fix by Ilia:
>
>         https://lore.kernel.org/r/20211115031808.7ab632ef@dtkw


FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Johan
>
>
> Changes in v2
>  - allow compile testing without CONFIG_OF (Andy)
>  - reword commit message to clarify that LITEX is neither a build or
>    runtime dependency and that the change only makes it easier to
>    compile test the driver
>  - move the Kconfig patch last in the series
>  - add Stafford's reviewed by tags to the two unmodified patches
>
>
> Johan Hovold (3):
>   serial: liteuart: fix use-after-free and memleak on unbind
>   serial: liteuart: fix minor-number leak on probe errors
>   serial: liteuart: relax compile-test dependencies
>
>  drivers/tty/serial/Kconfig    |  2 +-
>  drivers/tty/serial/liteuart.c | 18 +++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
>
> --
> 2.32.0
>


-- 
With Best Regards,
Andy Shevchenko