linux-kernel - Re: [PATCH 1/2] get_maintainer: look for configuration files in ./scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dleftjczmzgf35.fsf%l.stelmach@samsung.com>
Date:   Wed, 17 Nov 2021 13:07:58 +0100
From:   Lukasz Stelmach <l.stelmach@...sung.com>
To:     Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] get_maintainer: look for configuration files in
 ./scripts

It was <2021-11-16 wto 15:10>, when Joe Perches wrote:
> On Tue, 2021-11-16 at 22:34 +0100, Łukasz Stelmach wrote:
>> Change ".scripts" to "./scripts" as described in commit bcde44ed7d2a
>> ("scripts/get_maintainer.pl: use .get_maintainer.conf from . then $HOME
>> then scripts").
>
> The intent there was to use the <kernel_tree>/scripts directory

I am afraid bcde44ed7d2a[1] removed references to ${lk_path} and made
git_maintainer.pl look for the files in the directory the script is
invoked from.

> Adding . to that would change that.

Andrew points out[2] that some we might need to include .scripts
too. Where do we expect the config files to be (do comment)?

.                   - current directory (?)
${lk_path}/         - the top directory of source tree
${HOME}/            - per-user
${lk_path}/scripts  - how is this dfferent from ${lk_path}?
${lk_path}/.scripts - Andrew says someone might have started using it

I'd also add in this commit or another
${XDG_CONFIG_HOME}/get_maintainers. However, I think files in this
directory should be named conf and ignore instead of
.get_maintainer.conf and get_maintainer.ignore (respectively).

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bcde44ed7d2a
[2] https://lore.kernel.org/lkml/20211116135627.321aa8ef46ee389cf66692df@linux-foundation.org/
-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Download attachment "signature.asc" of type "application/pgp-signature" (488 bytes)