linux-kernel - Re: [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 07:27:43 -0600
From:   Samuel Holland <samuel@...lland.org>
To:     Robert Marko <robert.marko@...tura.hr>, robh+dt@...nel.org,
        mripard@...nel.org, wens@...e.org, jernej.skrabec@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     Ron Goossens <rgoossens@...il.com>
Subject: Re: [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode

On 11/17/21 3:47 AM, Robert Marko wrote:
> Orange Pi Zero Plus uses a Realtek RTL8211E RGMII Gigabit PHY, but its
> currently set to plain RGMII mode meaning that it doesn't introduce
> delays.
> 
> With this setup, TX packets are completely lost and changing the mode to
> RGMII-ID so the PHY will add delays internally fixes the issue.
> 
> Tested-by: Ron Goossens <rgoossens@...il.com>
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>

Tested-by: Samuel Holland <samuel@...lland.org>

Also please add:

Fixes: a7affb13b271 ("arm64: allwinner: H5: Add Xunlong Orange Pi Zero
Plus")

so this will get backported to stable releases.

Regards,
Samuel

> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> index d13980ed7a79..7ec5ac850a0d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> @@ -69,7 +69,7 @@ &emac {
>  	pinctrl-0 = <&emac_rgmii_pins>;
>  	phy-supply = <&reg_gmac_3v3>;
>  	phy-handle = <&ext_rgmii_phy>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  	status = "okay";
>  };
>  
>