linux-kernel - Re: [PATCH linux-next] USB: Delete the useless assignment to "nbytes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZUEVswwxLsNyV04@kroah.com>
Date:   Wed, 17 Nov 2021 14:32:06 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     cgel.zte@...il.com
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] USB: Delete the useless assignment to "nbytes"

On Thu, Nov 11, 2021 at 03:11:24PM +0000, cgel.zte@...il.com wrote:
> From: luo penghao <luo.penghao@....com.cn>
> 
> The assignment of the local variable "nbytes" in the if statement
> will not be used
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: luo penghao <luo.penghao@....com.cn>
> ---
>  drivers/usb/mon/mon_bin.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c
> index f48a23a..b8ba0f7 100644
> --- a/drivers/usb/mon/mon_bin.c
> +++ b/drivers/usb/mon/mon_bin.c
> @@ -845,7 +845,6 @@ static ssize_t mon_bin_read(struct file *file, char __user *buf,
>  			mutex_unlock(&rp->fetch_lock);
>  			return -EFAULT;
>  		}
> -		nbytes -= step_len;
>  		buf += step_len;
>  		rp->b_read += step_len;
>  		done += step_len;
> -- 
> 2.15.2
> 
> 

This patch is not correct (it's either wrong, or incomplete).  Please
fix your "robot" to not send changes that you have not properly
verified.

thanks,

greg k-h