linux-kernel - Re: [PATCH] media: mtk-jpeg: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 14:40:49 +0000
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Xu Wang <vulab@...as.ac.cn>, bin.liu@...iatek.com,
        matthias.bgg@...il.com, mchehab@...nel.org, rick.chang@...iatek.com
Cc:     linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mtk-jpeg: Remove unnecessary print function dev_err()

Quoting Xu Wang (2021-11-16 01:47:26)
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.

This one was also reporting errors in the case of -EPROBE_DEFER, which
will now go away, so this looks like a valid change to me.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index af994b9913a6..f332beb06d51 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1361,10 +1361,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
>         }
>  
>         jpeg_irq = platform_get_irq(pdev, 0);
> -       if (jpeg_irq < 0) {
> -               dev_err(&pdev->dev, "Failed to get jpeg_irq %d.\n", jpeg_irq);
> +       if (jpeg_irq < 0)
>                 return jpeg_irq;
> -       }
>  
>         ret = devm_request_irq(&pdev->dev, jpeg_irq,
>                                jpeg->variant->irq_handler, 0, pdev->name, jpeg);
> -- 
> 2.25.1
>