linux-kernel - drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 17 Nov 2021 23:10:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <helgaas@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol
 'mt7621_pci_ops' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8ab774587903771821b59471cc723bba6d893942
commit: 2bdd5238e756aac3ecbffc7c22b884485e84062e PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver
date:   4 weeks ago
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bdd5238e756aac3ecbffc7c22b884485e84062e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 2bdd5238e756aac3ecbffc7c22b884485e84062e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash drivers/pci/controller/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   command-line: note: in included file:
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
   builtin:0:0: sparse: this was the original definition
>> drivers/pci/controller/pcie-mt7621.c:151:16: sparse: sparse: symbol 'mt7621_pci_ops' was not declared. Should it be static?
   drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:151:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:151:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:130:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:130:1: sparse:     got void [noderef] __iomem *
   drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void const volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     expected void *
   arch/mips/include/asm/mips-cpc.h:100:1: sparse:     got void [noderef] __iomem *
   drivers/pci/controller/pcie-mt7621.c: note: in included file (through arch/mips/include/asm/mips-cps.h, arch/mips/include/asm/smp-ops.h, arch/mips/include/asm/smp.h, ...):
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *mem @@     got void * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void volatile [noderef] __iomem *mem
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:202:1: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void * @@     got void [noderef] __iomem * @@
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     expected void *
   arch/mips/include/asm/mips-cm.h:202:1: sparse:     got void [noderef] __iomem *
   arch/mips/include/asm/mips-cm.h:209:1: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void volatile [noderef] __iomem *mem @@     got void * @@

vim +/mt7621_pci_ops +151 drivers/pci/controller/pcie-mt7621.c

03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin       2018-03-15  150  
8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03 @151  struct pci_ops mt7621_pci_ops = {
8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03  152  	.map_bus	= mt7621_pcie_map_bus,
8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03  153  	.read		= pci_generic_config_read,
8571c62d45cb7e9 drivers/staging/mt7621-pci/pci-mt7621.c Sergio Paracuellos 2018-08-03  154  	.write		= pci_generic_config_write,
03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin       2018-03-15  155  };
03f152e31f4ae89 drivers/staging/mt7621-pci/pci-mt7621.c John Crispin       2018-03-15  156  

:::::: The code at line 151 was first introduced by commit
:::::: 8571c62d45cb7e9fdff87fe5132002d17fbce7a3 staging: mt7621-pci: use generic kernel pci subsystem read and write

:::::: TO: Sergio Paracuellos <sergio.paracuellos@...il.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71828 bytes)