linux-kernel - Re: [PATCH] drm/format-helper: Fix dst computation in drm_fb_xrgb8888_to_rgb888

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a827df6b-94fb-5948-90a1-8da000c132b6@marcan.st>
Date:   Thu, 18 Nov 2021 00:31:49 +0900
From:   Hector Martin <marcan@...can.st>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/format-helper: Fix dst computation in
 drm_fb_xrgb8888_to_rgb888_dstclip()

On 17/11/2021 23.56, Thomas Zimmermann wrote:
> Hi
> 
> Am 17.11.21 um 15:22 schrieb Hector Martin:
>> The dst pointer was being advanced by the clip width, not the full line
>> stride, resulting in corruption. The clip offset was also calculated
>> incorrectly.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Hector Martin <marcan@...can.st>
> 
> Thanks for your patch, but you're probably on the wrong branch. We
> rewrote this code recently and fixed the issue in drm-misc-next. [1][2]

Oops. I was on linux-next as of Nov 1. Looks like I missed it by a week!

Sounds like I'm going to have to rebase/rewrite the other series I just 
sent too...

-- 
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub