linux-kernel - Re: [PATCH RESEND] arm64: dts: mediatek: mt8516: remove 2 invalid i2c clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 18:28:23 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: mediatek: mt8516: remove 2 invalid i2c
 clocks



On 10/11/2021 20:35, Fabien Parent wrote:
> The two clocks "main-source" and "main-sel" are not present in the
> driver and not defined in the binding documentation. Remove them
> as they are not used and not described in the documentation.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>

Applied to v5.16-next/dts64

thanks

> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 27 ++++++------------------
>   1 file changed, 6 insertions(+), 21 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index bbe5a1419eff..d1b67c82d761 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -345,14 +345,9 @@ i2c0: i2c@...09000 {
>   			reg = <0 0x11009000 0 0x90>,
>   			      <0 0x11000180 0 0x80>;
>   			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_LOW>;
> -			clocks = <&topckgen CLK_TOP_AHB_INFRA_D2>,
> -				 <&infracfg CLK_IFR_I2C0_SEL>,
> -				 <&topckgen CLK_TOP_I2C0>,
> +			clocks = <&topckgen CLK_TOP_I2C0>,
>   				 <&topckgen CLK_TOP_APDMA>;
> -			clock-names = "main-source",
> -				      "main-sel",
> -				      "main",
> -				      "dma";
> +			clock-names = "main", "dma";
>   			#address-cells = <1>;
>   			#size-cells = <0>;
>   			status = "disabled";
> @@ -364,14 +359,9 @@ i2c1: i2c@...0a000 {
>   			reg = <0 0x1100a000 0 0x90>,
>   			      <0 0x11000200 0 0x80>;
>   			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_LOW>;
> -			clocks = <&topckgen CLK_TOP_AHB_INFRA_D2>,
> -				 <&infracfg CLK_IFR_I2C1_SEL>,
> -				 <&topckgen CLK_TOP_I2C1>,
> +			clocks = <&topckgen CLK_TOP_I2C1>,
>   				 <&topckgen CLK_TOP_APDMA>;
> -			clock-names = "main-source",
> -				      "main-sel",
> -				      "main",
> -				      "dma";
> +			clock-names = "main", "dma";
>   			#address-cells = <1>;
>   			#size-cells = <0>;
>   			status = "disabled";
> @@ -383,14 +373,9 @@ i2c2: i2c@...0b000 {
>   			reg = <0 0x1100b000 0 0x90>,
>   			      <0 0x11000280 0 0x80>;
>   			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>;
> -			clocks = <&topckgen CLK_TOP_AHB_INFRA_D2>,
> -				 <&infracfg CLK_IFR_I2C2_SEL>,
> -				 <&topckgen CLK_TOP_I2C2>,
> +			clocks = <&topckgen CLK_TOP_I2C2>,
>   				 <&topckgen CLK_TOP_APDMA>;
> -			clock-names = "main-source",
> -				      "main-sel",
> -				      "main",
> -				      "dma";
> +			clock-names = "main", "dma";
>   			#address-cells = <1>;
>   			#size-cells = <0>;
>   			status = "disabled";
>