linux-kernel - Re: [PATCH 1/3] arm64: dts: mt8183: add dpi node to mt8183

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 19:21:14 +0100
From:   Fabien Parent <fparent@...libre.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Jitao Shi <jitao.shi@...iatek.com>,
        DTML <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: mt8183: add dpi node to mt8183

Hi Matthias,


On Wed, Nov 17, 2021 at 6:33 PM Matthias Brugger <matthias.bgg@...il.com> wrote:
>
>
>
> On 10/11/2021 20:24, Fabien Parent wrote:
> > From: Pi-Hsun Shih <pihsun@...omium.org>
> >
> > Add dpi node to mt8183.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> > Signed-off-by: Pi-Hsun Shih <pihsun@...omium.org>
> > Signed-off-by: Fabien Parent <fparent@...libre.com>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index ba4584faca5a..7c283c0b68b5 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1443,6 +1443,17 @@ dsi0: dsi@...14000 {
> >                       phy-names = "dphy";
> >               };
> >
> > +             dpi0: dpi@...15000 {
> > +                     compatible = "mediatek,mt8183-dpi";
> > +                     reg = <0 0x14015000 0 0x1000>;
> > +                     interrupts = <GIC_SPI 237 IRQ_TYPE_LEVEL_LOW>;
> > +                     power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> > +                     clocks = <&mmsys CLK_MM_DPI_IF>,
> > +                              <&mmsys CLK_MM_DPI_MM>,
> > +                              <&apmixedsys CLK_APMIXED_TVDPLL>;
> > +                     clock-names = "pixel", "engine", "pll";
>
>
> We are missing the output port node, don't we?

The output port node is defined in: [PATCH 2/3] arm64: dts: mediatek:
mt8183-pumpkin: add HDMI support
Unlike MT8173, there is no HDMI IP in the MT8183 SoC.

>
> Regards,
> Matthias
>
> > +             };
> > +
> >               mutex: mutex@...16000 {
> >                       compatible = "mediatek,mt8183-disp-mutex";
> >                       reg = <0 0x14016000 0 0x1000>;
> >