linux-kernel - [PATCH v3] watchdog: Add warning message when the newcpumask contains nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211118031046.32632-1-qiang.zhang1211@gmail.com>
Date:   Thu, 18 Nov 2021 11:10:46 +0800
From:   Zqiang <qiang.zhang1211@...il.com>
To:     frederic@...nel.org, pmladek@...e.com
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        Zqiang <qiang.zhang1211@...il.com>
Subject: [PATCH v3] watchdog: Add warning message when the newcpumask contains nohz_full cores

The watchdog default is disabled on nohz_full cores, however when
override the cpumask, if new cpumask contains nohz_full cores,
add warning message.

Signed-off-by: Zqiang <qiang.zhang1211@...il.com>
---
 v1->v2:
 if watchdog_cpumask became empty, set housekeeping_cpumask.
 v2->v3:
 only print a warning when a nohz_full CPU is included in new cpumask.

 kernel/watchdog.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index ad912511a0c0..37a978d8ff06 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -629,6 +629,7 @@ static void proc_watchdog_update(void)
 {
 	/* Remove impossible cpus to keep sysctl output clean. */
 	cpumask_and(&watchdog_cpumask, &watchdog_cpumask, cpu_possible_mask);
+	WARN_ONCE(!cpumask_subset(&watchdog_cpumask, housekeeping_cpumask(HK_FLAG_TIMER)), "Enabling watchdog on nohz_full cores\n");
 	lockup_detector_reconfigure();
 }
 
-- 
2.17.1