linux-kernel - Re: [PATCH v4 00/25] Unify PCI error response checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211118204421.GA1881943@bhelgaas>
Date:   Thu, 18 Nov 2021 14:44:21 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Naveen Naidu <naveennaidu479@...il.com>
Cc:     bhelgaas@...gle.com,
        Krzysztof Wilczyński <kw@...ux.com>,
        linux-hyperv@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>,
        linux-pci@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>,
        Binghui Wang <wangbinghui@...ilicon.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Russell Currey <ruscur@...sell.cc>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Toan Le <toan@...amperecomputing.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Nirmal Patel <nirmal.patel@...ux.intel.com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Rob Herring <robh@...nel.org>, Wei Liu <wei.liu@...nel.org>,
        linux-samsung-soc@...r.kernel.org, Marc Zyngier <maz@...nel.org>,
        Joyce Ooi <joyce.ooi@...el.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Jianjun Wang <jianjun.wang@...iatek.com>,
        linux-rockchip@...ts.infradead.org,
        "maintainer:BROADCOM IPROC ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        Jonathan Derrick <jonathan.derrick@...ux.dev>,
        Xiaowei Song <songxiaowei@...ilicon.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Robert Richter <rric@...nel.org>,
        Sean V Kelley <sean.v.kelley@...el.com>,
        Ray Jui <rjui@...adcom.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        linux-mediatek@...ts.infradead.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        linux-arm-kernel@...ts.infradead.org,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
        Scott Branden <sbranden@...adcom.com>,
        linuxppc-dev@...ts.ozlabs.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Lukas Wunner <lukas@...ner.de>,
        Jingoo Han <jingoohan1@...il.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v4 00/25] Unify PCI error response checking

On Thu, Nov 18, 2021 at 07:33:10PM +0530, Naveen Naidu wrote:
> An MMIO read from a PCI device that doesn't exist or doesn't respond
> causes a PCI error.  There's no real data to return to satisfy the 
> CPU read, so most hardware fabricates ~0 data.
> 
> This patch series adds PCI_ERROR_RESPONSE definition and other helper
> definition PCI_SET_ERROR_RESPONSE and PCI_POSSIBLE_ERROR and uses it
> where appropriate to make these checks consistent and easier to find.
> 
> This helps unify PCI error response checking and make error check
> consistent and easier to find.
> 
> This series also ensures that the error response fabrication now happens
> in the PCI_OP_READ and PCI_USER_READ_CONFIG. This removes the
> responsibility from controller drivers to do the error response setting. 

Applied to pci/error for v5.17.  Thanks, this is really nice work.
Somehow small changes like these add up to something much greater than
one would expect.

This touches many native controller drivers but in trivial ways, so I
plan to merge this branch after the usual native controller stuff from
Lorenzo.

I tweaked the commit logs to clarify that this series is all about
*config* reads, not MMIO reads.  MMIO reads have similar issues, and
we can use PCI_ERROR_RESPONSE, etc., there, too, but that's not what
this series does.

Bjorn