linux-kernel - RE: [agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN1PR12MB257567FC4234239ED1BEE0E7E39B9@SN1PR12MB2575.namprd12.prod.outlook.com>
Date:   Thu, 18 Nov 2021 21:52:14 +0000
From:   "Errabolu, Ramesh" <Ramesh.Errabolu@....com>
To:     kernel test robot <lkp@...el.com>
CC:     "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Kuehling, Felix" <Felix.Kuehling@....com>
Subject: RE: [agd5f:drm-next 51/92]
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous
 prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'

[AMD Official Use Only]

Felix,

Could you advise if I should submit a patch to fix the warning. The api under question (amdgpu_amdkfd_gpuvm_unpin_bo) MUST be non-static in DKMS branch. However it could be specified as static on drm-next. What is the policy under such situations. Let me know.

Regards,
Ramesh

-----Original Message-----
From: kernel test robot <lkp@...el.com>
Sent: Thursday, November 18, 2021 2:00 PM
To: Errabolu, Ramesh <Ramesh.Errabolu@....com>
Cc: llvm@...ts.linux.dev; kbuild-all@...ts.01.org; linux-kernel@...r.kernel.org; Deucher, Alexander <Alexander.Deucher@....com>; Kuehling, Felix <Felix.Kuehling@....com>
Subject: [agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'

[CAUTION: External Email]

tree:   https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux.git&amp;data=04%7C01%7CRamesh.Errabolu%40amd.com%7Cb83bf0b9d065404f642808d9aace10f3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637728627265110891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=K8TrE3DWtsNrw4qWrttGfGdL71w3w9Gv1KUCOq1zWHk%3D&amp;reserved=0 drm-next
head:   eaae0714f4a82df81a60c6aae74c568e8974a716
commit: f140fc51a32ef8637b522a880b8f9f14683ce8df [51/92] drm/amdgpu: Pin MMIO/DOORBELL BO's in GTT  domain
config: x86_64-randconfig-r001-20211118 (attached as .config) reproduce (this is a W=1 build):
        wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&amp;data=04%7C01%7CRamesh.Errabolu%40amd.com%7Cb83bf0b9d065404f642808d9aace10f3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637728627265120880%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=OEvXACWiWtGXk1em3DdxFBHWJEQ8InliJUbr9FLoKbU%3D&amp;reserved=0 -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add agd5f https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux.git&amp;data=04%7C01%7CRamesh.Errabolu%40amd.com%7Cb83bf0b9d065404f642808d9aace10f3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637728627265120880%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=Mc0JG24aLBE%2B%2Bo073hnBipZMP8LicS3oeiXufr3h4Bo%3D&amp;reserved=0
        git fetch --no-tags agd5f drm-next
        git checkout f140fc51a32ef8637b522a880b8f9f14683ce8df
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no 
>> previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
>> [-Wmissing-prototypes]
   void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
        ^
   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
   ^
   static
   1 warning generated.


vim +/amdgpu_amdkfd_gpuvm_unpin_bo +1335 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

  1326
  1327  /**
  1328   * amdgpu_amdkfd_gpuvm_unpin_bo() - Unpins BO using following criteria
  1329   * @bo: Handle of buffer object being unpinned
  1330   *
  1331   *   - Is a illegal request for USERPTR BOs and is ignored
  1332   *   - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
  1333   *     PIN count decremented. Calls to UNPIN must balance calls to PIN
  1334   */
> 1335  void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
  1336  {
  1337          int ret = 0;
  1338
  1339          ret = amdgpu_bo_reserve(bo, false);
  1340          if (unlikely(ret))
  1341                  return;
  1342
  1343          amdgpu_bo_unpin(bo);
  1344          amdgpu_bo_unreserve(bo);
  1345  }
  1346

---
0-DAY CI Kernel Test Service, Intel Corporation
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&amp;data=04%7C01%7CRamesh.Errabolu%40amd.com%7Cb83bf0b9d065404f642808d9aace10f3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637728627265120880%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=iNtsNcsj43m1oShIaDr3W%2FVTj0uSOtcI2RU9u04CuDA%3D&amp;reserved=0