linux-kernel - [PATCH 5.14] block: Add a helper to validate the block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211118235756.1128122-1-tadeusz.struk@linaro.org>
Date:   Thu, 18 Nov 2021 15:57:56 -0800
From:   Tadeusz Struk <tadeusz.struk@...aro.org>
To:     stable@...r.kernel.org
Cc:     tadeusz.struk@...aro.org, axboe@...nel.dk, hch@....de,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+662448179365dddc1880@...kaller.appspotmail.com,
        xieyongji@...edance.com
Subject: [PATCH 5.14] block: Add a helper to validate the block size

From: Xie Yongji <xieyongji@...edance.com>

From: Xie Yongji <xieyongji@...edance.com>

There are some duplicated codes to validate the block
size in block drivers. This limitation actually comes
from block layer, so this patch tries to add a new block
layer helper for that.

Signed-off-by: Xie Yongji <xieyongji@...edance.com>
Link: https://lore.kernel.org/r/20211026144015.188-2-xieyongji@bytedance.com
Signed-off-by: Jens Axboe <axboe@...nel.dk>
Signed-off-by: Tadeusz Struk <tadeusz.struk@...aro.org>
---
 include/linux/blkdev.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index e7979fe7e4fa..84019910446a 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -59,6 +59,14 @@ struct blk_keyslot_manager;
  */
 #define BLKCG_MAX_POLS		6
 
+static inline int blk_validate_block_size(unsigned int bsize)
+{
+	if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
+		return -EINVAL;
+
+	return 0;
+}
+
 typedef void (rq_end_io_fn)(struct request *, blk_status_t);
 
 /*
-- 
2.33.1