[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211117202935.10fcf82d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Wed, 17 Nov 2021 20:29:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
Leon Romanovsky <leonro@...dia.com>,
Danielle Ratson <danieller@...dia.com>,
Jiri Pirko <jiri@...dia.com>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, Amit Cohen <amcohen@...dia.com>
Subject: Re: [PATCH net v1] devlink: Don't throw an error if flash
notification sent before devlink visible
On Wed, 17 Nov 2021 16:49:09 +0200 Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
>
> The mlxsw driver calls to various devlink flash routines even before
> users can get any access to the devlink instance itself. For example,
> mlxsw_core_fw_rev_validate() one of such functions.
>
> __mlxsw_core_bus_device_register
> -> mlxsw_core_fw_rev_validate
> -> mlxsw_core_fw_flash
> -> mlxfw_firmware_flash
> -> mlxfw_status_notify
> -> devlink_flash_update_status_notify
> -> __devlink_flash_update_notify
> -> WARN_ON(...)
>
> It causes to the WARN_ON to trigger warning about devlink not registered.
>
> Fixes: cf530217408e ("devlink: Notify users when objects are accessible")
> Reported-by: Danielle Ratson <danieller@...dia.com>
> Tested-by: Danielle Ratson <danieller@...dia.com>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
Acked-by: Jakub Kicinski <kuba@...nel.org>
Powered by blists - more mailing lists