linux-kernel - Re: [PATCH] nfc: st-nci: Fix potential buffer overflows in EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211117204214.5fe26708@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 17 Nov 2021 20:42:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jordy Zomer <jordy@...ing.systems>
Cc:     linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "David S. Miller" <davem@...emloft.net>,
        wengjianfeng <wengjianfeng@...ong.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] nfc: st-nci: Fix potential buffer overflows in
 EVT_TRANSACTION

On Wed, 17 Nov 2021 18:15:51 +0100 Jordy Zomer wrote:
> +
> +		// Checking if the length of the AID is valid
> +		if (transaction->aid_len > sizeof(transaction->aid))
> +			return -EINVAL;
> +
> +

Please remove the double blank lines and use more common style of
multi-line comments /* */ like the rest of this file.

Same for the other patch. Thanks!