linux-kernel - Re: [PATCH 6/7] perf: x86/core: Add interface to query perfmon_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Nov 2021 16:06:26 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Like Xu <likexu@...cent.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 6/7] perf: x86/core: Add interface to query
 perfmon_event_map[] directly

On 18/11/2021 7:21 am, kernel test robot wrote:
> Hi Like,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on kvm/queue]
> [also build test ERROR on tip/perf/core mst-vhost/linux-next linus/master v5.16-rc1 next-20211117]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 

...

> vim +500 arch/x86/include/asm/perf_event.h
> 
>     492	
>     493	#if defined(CONFIG_PERF_EVENTS) && defined(CONFIG_CPU_SUP_INTEL)
>     494	extern struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
>     495	extern u64 perf_get_hw_event_config(int perf_hw_id);
>     496	extern int x86_perf_get_lbr(struct x86_pmu_lbr *lbr);
>     497	#else
>     498	struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
>     499	u64 perf_get_hw_event_config(int perf_hw_id);

Thanks to the robot, I should have removed the ";" from this line.

Awaiting further review comments.

>   > 500	{
>     501		return 0;
>     502	}
>     503	static inline int x86_perf_get_lbr(struct x86_pmu_lbr *lbr)
>     504	{
>     505		return -1;
>     506	}
>     507	#endif
>     508	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>