linux-kernel - Re: [PATCH V3] pwm: rcar: Use div64_ul instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211118084108.vfdyogbd25bwnyzf@pengutronix.de>
Date:   Thu, 18 Nov 2021 09:41:08 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     cgel.zte@...il.com
Cc:     deng.changcheng@....com.cn, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
        thierry.reding@...il.com, zealci@....com.cn
Subject: Re: [PATCH V3] pwm: rcar: Use div64_ul instead of do_div

On Thu, Nov 18, 2021 at 03:02:15AM +0000, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> do_div() does a 64-by-32 division. Here the divisor is an unsigned long
> which on some platforms is 64 bit wide. So use div64_ul instead of do_div
> to avoid a possible truncation.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>

You're supposed to add a S-o-b line for yourself with a email address
that matches the sender of the patch.

Other than that the patch looks fine now.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)