linux-kernel - Re: [PATCH 2/2] ASoC: rt5682s: Fix crash due to out of scope stack vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n52AAfNqYP5MM1CUntkM15ftskuPVRNyCbBdCbp8mFHL2Q@mail.gmail.com>
Date:   Wed, 17 Nov 2021 17:36:27 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Rob Clark <robdclark@...il.com>, alsa-devel@...a-project.org
Cc:     Derek Fang <derek.fang@...ltek.com>, linux-arm-msm@...r.kernel.org,
        Rob Clark <robdclark@...omium.org>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: rt5682s: Fix crash due to out of scope stack vars

Quoting Rob Clark (2021-11-17 17:04:53)
> From: Rob Clark <robdclark@...omium.org>
>
> Move the declaration of temporary arrays to somewhere that won't go out
> of scope before the devm_clk_hw_register() call, lest we be at the whim
> of the compiler for whether those stack variables get overwritten.
>
> Fixes a crash seen with gcc version 11.2.1 20210728 (Red Hat 11.2.1-1)
>
> Fixes: bdd229ab26be ("ASoC: rt5682s: Add driver for ALC5682I-VS codec")
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>