linux-kernel - Re: [PATCH] of: property: fw_devlink: Fixup behaviour when 'node_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZZfvU2SQp5A09vF@robh.at.kernel.org>
Date:   Thu, 18 Nov 2021 08:14:21 -0600
From:   Rob Herring <robh@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Saravana Kannan <saravanak@...gle.com>,
        Dmitry Osipenko <digetx@...il.com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>,
        linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] of: property: fw_devlink: Fixup behaviour when
 'node_not_dev' is set

On Thu, 02 Sep 2021 11:02:21 +0200, Ulf Hansson wrote:
> In the struct supplier_bindings the member 'node_not_dev' is described as
> "The consumer node containing the property is never a device.", but that is
> inconsistent with the behaviour of the code in of_link_property(), as it
> calls of_get_compat_node() that starts parsing for a compatible property
> from the node it gets passed to it. The proper behaviour is to start at the
> node's parent, so let's do that.
> 
> While at it, let's take the opportunity to update the description of the
> 'node_not_dev' flag, as to clarify its purpose.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
>  drivers/of/property.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 

Applied, thanks!