linux-kernel - Re: [PATCH net] can: m_can: pci: fix iomap_read_fifo() and iomap_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca1c6275-1609-466e-95b5-d7ad5083f666@linux.intel.com>
Date:   Thu, 18 Nov 2021 17:09:35 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Felipe Balbi (Intel)" <balbi@...nel.org>,
        Matt Kline <matt@...bashing.io>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] can: m_can: pci: fix iomap_read_fifo() and
 iomap_write_fifo()

On 11/18/21 4:40 PM, Matthias Schiffer wrote:
> The same fix that was previously done in m_can_platform in commit
> 99d173fbe894 ("can: m_can: fix iomap_read_fifo() and iomap_write_fifo()")
> is required in m_can_pci as well to make iomap_read_fifo() and
> iomap_write_fifo() work for val_count > 1.
> 
> Fixes: 812270e5445b ("can: m_can: Batch FIFO writes during CAN transmit")
> Fixes: 1aa6772f64b4 ("can: m_can: Batch FIFO reads during CAN receive")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> ---
>   drivers/net/can/m_can/m_can_pci.c | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
I tested this on top of plain v5.15 (v5.16-rc1 has some rootfs 
regression on my EHL HW) where my test case was receiving zeros and this 
makes it working again like in v5.14 and earlier.

Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>