linux-kernel - Re: [PATCH] arm64: extable: remove unsed ex_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211118151317.GA9977@lakrids.cambridge.arm.com>
Date:   Thu, 18 Nov 2021 15:13:28 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Jisheng Zhang <jszhang3@...l.ustc.edu.cn>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: extable: remove unsed ex_handler_t definition

On Thu, Nov 18, 2021 at 08:02:49PM +0800, Jisheng Zhang wrote:
> From: Jisheng Zhang <jszhang@...nel.org>
> 
> The type ex_handler_t is defined but not used, remove it.

It's probably worth saying:

| The ex_handler_t type was introduced in commit:
|
|   d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields")
| 
| ... but has never been used, and is unnecessary. Remove it.

... as this was a leftover from a prior version of that patch, and in
the form merged in mainline it was redundant becuase we moved to using
an enumerated type rather than a function pointer in the ex_table_entry.

> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>

With or without the wording above:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.

> ---
>  arch/arm64/mm/extable.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
> index c3d53811a15e..c0181e60cc98 100644
> --- a/arch/arm64/mm/extable.c
> +++ b/arch/arm64/mm/extable.c
> @@ -10,9 +10,6 @@
>  #include <asm/asm-extable.h>
>  #include <asm/ptrace.h>
>  
> -typedef bool (*ex_handler_t)(const struct exception_table_entry *,
> -			     struct pt_regs *);
> -
>  static inline unsigned long
>  get_ex_fixup(const struct exception_table_entry *ex)
>  {
> -- 
> 2.33.0
> 
>