linux-kernel - Re: [PATCH] skbuff: suppress clang object-size-mismatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211118083833.3c2805d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 18 Nov 2021 08:38:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tadeusz Struk <tadeusz.struk@...aro.org>
Cc:     David Miller <davem@...emloft.net>, elver@...gle.com,
        nathan@...nel.org, ndesaulniers@...gle.com,
        jonathan.lemon@...il.com, alobakin@...me, willemb@...gle.com,
        pabeni@...hat.com, cong.wang@...edance.com, haokexin@...il.com,
        ilias.apalodimas@...aro.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        keescook@...omium.org, edumazet@...gle.com
Subject: Re: [PATCH] skbuff: suppress clang object-size-mismatch error

On Thu, 18 Nov 2021 08:05:01 -0800 Tadeusz Struk wrote:
> On 11/12/21 07:42, David Miller wrote:
> > From: Jakub Kicinski <kuba@...nel.org>
> > Date: Thu, 11 Nov 2021 09:54:44 -0800
> >   
> >> I'm not sure if that stalled due to lack of time or some fundamental
> >> problems.  
> > 
> > ran out of time, then had a stroke...
> >   
> >> Seems like finishing that would let us clean up such misuses?  
> > 
> > yes it would
> 
> so since there is not better way of suppressing the issue atm are
> you ok with taking this fix for now?

I vote no on sprinkling ugly tags around to silence some random
checkers warning. We already have too many of them. They are 
meaningless and confusing to people reading the code.

This is not a fundamental problem, the solution is clear.