linux-kernel - Re: [PATCH 5.10 11/21] arm64: vdso32: suppress error message for make mrproper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 14:24:09 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Lucas Henneman <henneman@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Will Deacon <will@...nel.org>
Subject: Re: [PATCH 5.10 11/21] arm64: vdso32: suppress error message for make mrproper

On Fri, Nov 19, 2021 at 1:47 PM Pavel Machek <pavel@...x.de> wrote:
>
> Hi!
>
> > commit 14831fad73f5ac30ac61760487d95a538e6ab3cb upstream.
> >
> > When running the following command without arm-linux-gnueabi-gcc in
> > one's $PATH, the following warning is observed:
> >
> > $ ARCH=arm64 CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make -j72 LLVM=1 mrproper
> > make[1]: arm-linux-gnueabi-gcc: No such file or directory
> >
> > This is because KCONFIG is not run for mrproper, so CONFIG_CC_IS_CLANG
> > is not set, and we end up eagerly evaluating various variables that try
> > to invoke CC_COMPAT.
>
> Upstream commit is fine, but 5.10 port misses the 2> part of the
> change.

You're right; thanks for the report. Greg, can you drop this version
of the backport for 5.10 and 5.4? I'll resubmit an updated version.

>
> > +++ b/arch/arm64/kernel/vdso32/Makefile
> > @@ -48,7 +48,8 @@ cc32-as-instr = $(call try-run,\
> >  # As a result we set our own flags here.
> >
> >  # KBUILD_CPPFLAGS and NOSTDINC_FLAGS from top-level Makefile
> > -VDSO_CPPFLAGS := -D__KERNEL__ -nostdinc -isystem $(shell $(CC_COMPAT) -print-file-name=include)
> > +VDSO_CPPFLAGS := -D__KERNEL__ -nostdinc
> > +VDSO_CPPFLAGS += -isystem $(shell $(CC_COMPAT) -print-file-name=include)
> >  VDSO_CPPFLAGS += $(LINUXINCLUDE)
> >
> >  # Common C and assembly flags
> >
>
> Best regards,
>                                                                 Pavel
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany



-- 
Thanks,
~Nick Desaulniers