linux-kernel - [PATCH V1] arm64: kvm-ptp: Fix unreasonable return value judgment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <f94da8a27102a29bb178d5ca237b9e5760154238.1637289060.git.xhao@linux.alibaba.com>
Date:   Fri, 19 Nov 2021 10:36:44 +0800
From:   Xin Hao <xhao@...ux.alibaba.com>
To:     richardcochran@...il.com
Cc:     xhao@...ux.alibaba.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH V1] arm64: kvm-ptp: Fix unreasonable return value judgment

In kvm_arch_ptp_init() func, it calls kvm_arm_hyp_service_available()
which return value is bool type, the return value cannot be less than 0
So there fix it.

Signed-off-by: Xin Hao <xhao@...ux.alibaba.com>
---
 drivers/ptp/ptp_kvm_arm.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/ptp/ptp_kvm_arm.c b/drivers/ptp/ptp_kvm_arm.c
index b7d28c8dfb84..38b06e87a192 100644
--- a/drivers/ptp/ptp_kvm_arm.c
+++ b/drivers/ptp/ptp_kvm_arm.c
@@ -13,10 +13,7 @@
 
 int kvm_arch_ptp_init(void)
 {
-	int ret;
-
-	ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
-	if (ret <= 0)
+	if (!kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP))
 		return -EOPNOTSUPP;
 
 	return 0;
-- 
2.31.0