[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <FEEBC8B5-EF20-41A7-9883-018C6B25C6B6@oracle.com>
Date: Fri, 19 Nov 2021 02:50:11 +0000
From: Eric Snowberg <eric.snowberg@...cle.com>
To: Mimi Zohar <zohar@...ux.ibm.com>
CC: "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
"linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
"dhowells@...hat.com" <dhowells@...hat.com>,
"dwmw2@...radead.org" <dwmw2@...radead.org>,
"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
"davem@...emloft.net" <davem@...emloft.net>,
Jarkko Sakkinen <jarkko@...nel.org>,
"jmorris@...ei.org" <jmorris@...ei.org>,
"serge@...lyn.com" <serge@...lyn.com>,
"keescook@...omium.org" <keescook@...omium.org>,
"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
"weiyongjun1@...wei.com" <weiyongjun1@...wei.com>,
"nayna@...ux.ibm.com" <nayna@...ux.ibm.com>,
"ebiggers@...gle.com" <ebiggers@...gle.com>,
"ardb@...nel.org" <ardb@...nel.org>,
"nramas@...ux.microsoft.com" <nramas@...ux.microsoft.com>,
"lszubowi@...hat.com" <lszubowi@...hat.com>,
"jason@...c4.com" <jason@...c4.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
"linux-security-module@...r.kernel.org"
<linux-security-module@...r.kernel.org>,
"James.Bottomley@...senpartnership.com"
<James.Bottomley@...senPartnership.com>,
"pjones@...hat.com" <pjones@...hat.com>,
Konrad Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH v7 11/17] KEYS: Introduce link restriction for machine
keys
> On Nov 18, 2021, at 5:20 PM, Mimi Zohar <zohar@...ux.ibm.com> wrote:
>
> Hi Eric,
>
> On Mon, 2021-11-15 at 19:15 -0500, Eric Snowberg wrote:
>> Introduce a new link restriction that includes the trusted builtin,
>> secondary and machine keys. The restriction is based on the key to be
>> added being vouched for by a key in any of these three keyrings.
>>
>> Suggested-by: Mimi Zohar <zohar@...ux.ibm.com>
>> Signed-off-by: Eric Snowberg <eric.snowberg@...cle.com>
>> ---
>> v3: Initial version
>> v4: moved code under CONFIG_INTEGRITY_MOK_KEYRING
>> v5: Rename to machine keyring
>> v6: Change subject name (suggested by Mimi)
>> Rename restrict_link_by_builtin_secondary_and_ca_trusted
>> to restrict_link_by_builtin_secondary_and_machine (suggested by
>> Mimi)
>> v7: Unmodified from v6
>> ---
>> certs/system_keyring.c | 23 +++++++++++++++++++++++
>> include/keys/system_keyring.h | 6 ++++++
>> 2 files changed, 29 insertions(+)
>>
>> diff --git a/certs/system_keyring.c b/certs/system_keyring.c
>> index bc7e44fc82c2..71a00add9805 100644
>> --- a/certs/system_keyring.c
>> +++ b/certs/system_keyring.c
>> @@ -99,6 +99,29 @@ void __init set_machine_trusted_keys(struct key *keyring)
>> {
>> machine_trusted_keys = keyring;
>> }
>> +
>> +/**
>
> This begins the start of kernel doc.
>
>> + * restrict_link_by_builtin_secondary_and_machine
>
> Missing are the parameter defintions. Please refer to
> Documentation/doc-guide/kernel-doc.rst for details.
I’ll add this in the next round, thanks.
Powered by blists - more mailing lists