[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211119025359.30815-4-Meng.Li@windriver.com>
Date: Fri, 19 Nov 2021 10:53:56 +0800
From: Meng Li <Meng.Li@...driver.com>
To: stable@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
mcoquelin.stm32@...il.com, linux@...linux.org.uk, andrew@...n.ch,
qiangqing.zhang@....com
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
meng.li@...driver.com
Subject: [PATCH 3/6] net: stmmac: fix missing unlock on error in stmmac_suspend()
From: Yang Yingliang <yangyingliang@...wei.com>
commit 30f347ae7cc1178c431f968a89d4b4a375bc0d39 upstream
Add the missing unlock before return from stmmac_suspend()
in the error handling case.
Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
Signed-off-by: Meng Li <Meng.Li@...driver.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 498962c4b59e..51626edc6a4c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -5275,8 +5275,10 @@ int stmmac_suspend(struct device *dev)
/* Disable clock in case of PWM is off */
clk_disable_unprepare(priv->plat->clk_ptp_ref);
ret = pm_runtime_force_suspend(dev);
- if (ret)
+ if (ret) {
+ mutex_unlock(&priv->lock);
return ret;
+ }
}
mutex_unlock(&priv->lock);
--
2.17.1
Powered by blists - more mailing lists