linux-kernel - Re: [PATCH v3 1/3] arm64: dts: qcom: sc7280: Fix incorrect clock name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZcZ6O4DxUUNothC@builder.lan>
Date:   Thu, 18 Nov 2021 21:28:40 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Prasad Malisetty <pmaliset@...eaurora.org>
Cc:     swboyd@...omium.org, agross@...nel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        manivannan.sadhasivam@...aro.org, robh+dt@...nel.org,
        mka@...omium.org, lorenzo.pieralisi@....com, svarbanov@...sol.com,
        bhelgaas@...gle.com
Subject: Re: [PATCH v3 1/3] arm64: dts: qcom: sc7280: Fix incorrect clock name

On Tue 16 Nov 05:01 CST 2021, Prasad Malisetty wrote:

> Replace pcie_1_pipe-clk clock name with pcie_1_pipe_clk
> To match with dt binding.
> 
> Fixes: ab7772de8612 ("arm64: dts: qcom: SC7280: Add rpmhcc clock controller node")
> 
> Signed-off-by: Prasad Malisetty <pmaliset@...eaurora.org>
> Reported-by: kernel test robot <lkp@...el.com>

This says "lkp reported an issue and this patch fixes that issue", but
looking back I think you picked up this tag because lkp had problems
building v1 of this patch.

I will drop it while applying the patch and I will remove the empty line
between Fixes and your S-o-b.

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 365a2e0..cb94b87 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -576,7 +576,7 @@
>  				 <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
>  				 <0>, <0>, <0>, <0>, <0>, <0>;
>  			clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
> -				      "pcie_0_pipe_clk", "pcie_1_pipe-clk",
> +				      "pcie_0_pipe_clk", "pcie_1_pipe_clk",
>  				      "ufs_phy_rx_symbol_0_clk", "ufs_phy_rx_symbol_1_clk",
>  				      "ufs_phy_tx_symbol_0_clk",
>  				      "usb3_phy_wrapper_gcc_usb30_pipe_clk";
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>