[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <002701d7dd05$d252b690$76f823b0$@codeaurora.org>
Date: Fri, 19 Nov 2021 10:55:04 +0530
From: "Rakesh Pillai" <pillair@...eaurora.org>
To: "'Stephen Boyd'" <swboyd@...omium.org>, <agross@...nel.org>,
<bjorn.andersson@...aro.org>, <robh+dt@...nel.org>
Cc: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <sibis@...eaurora.org>,
<mpubbise@...eaurora.org>, <kuabhs@...omium.org>
Subject: RE: [PATCH v6] arm64: dts: qcom: sc7280: Add WPSS remoteproc node
> -----Original Message-----
> From: Stephen Boyd <swboyd@...omium.org>
> Sent: Friday, November 19, 2021 6:22 AM
> To: Rakesh Pillai <pillair@...eaurora.org>; agross@...nel.org;
> bjorn.andersson@...aro.org; robh+dt@...nel.org
> Cc: linux-arm-msm@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; sibis@...eaurora.org; mpubbise@...eaurora.org;
> kuabhs@...omium.org
> Subject: Re: [PATCH v6] arm64: dts: qcom: sc7280: Add WPSS remoteproc
> node
>
> Quoting Rakesh Pillai (2021-11-18 07:56:56)
> > Add the WPSS remoteproc node in dts for PIL loading.
> >
> > Signed-off-by: Rakesh Pillai <pillair@...eaurora.org>
> > ---
> > Changes from v5:
> > - Update the clock names
> > ---
> > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 +++
> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 56
> +++++++++++++++++++++++++++++++++
> > 2 files changed, 60 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > index 9b991ba..ddab150 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> > @@ -80,3 +80,7 @@
> > qcom,pre-scaling = <1 1>;
> > };
> > };
> > +
> > +&remoteproc_wpss {
> > + status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 365a2e0..76c2a90 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -134,6 +134,11 @@
> > no-map;
> > };
> >
> > + wpss_mem: memory@...00000 {
> > + no-map;
> > + reg = <0x0 0x9ae00000 0x0 0x1900000>;
>
> Almost always reg comes first. Please swap the order of these two
> properties.
Hi Stephen,
I have fixed this and sent v7 for the DTSI change.
Thanks,
Rakesh Pillai
>
> > + };
> > +
> > rmtfs_mem: memory@...00000 {
> > compatible = "qcom,rmtfs-mem";
> > reg = <0x0 0x9c900000 0x0 0x280000>;
>
> Otherwise
>
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
Powered by blists - more mailing lists