linux-kernel - Re: [PATCH v1 0/2] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b99aabbe-add9-9c1e-ed4b-8850c69233de@accesio.com>
Date:   Thu, 18 Nov 2021 22:32:51 -0800
From:   Jay Dolan <jay.dolan@...esio.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc:     Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver

On 11/17/21 6:57 AM, Andy Shevchenko wrote:
> Split Pericom driver to a separate module.
> While at it, re-enable high baud rates.
> 
> Jay, can you, please, test this on as many hardware as you have?
> 
> The series depends on the fix-series: https://lore.kernel.org/linux-serial/20211117145502.43645-1-andriy.shevchenko@linux.intel.com/T/#u
> 
> Andy Shevchenko (1):
>    serial: 8250_pci: Split out Pericom driver
> 
> Jay Dolan (1):
>    serial: 8250_pericom: Re-enable higher baud rates
> 
>   drivers/tty/serial/8250/8250_pci.c     | 405 +------------------------
>   drivers/tty/serial/8250/8250_pericom.c | 217 +++++++++++++
>   drivers/tty/serial/8250/Kconfig        |   8 +
>   drivers/tty/serial/8250/Makefile       |   1 +
>   4 files changed, 231 insertions(+), 400 deletions(-)
>   create mode 100644 drivers/tty/serial/8250/8250_pericom.c
> 

I have my current state here: 
https://github.com/accesio/linux/blob/split-pericom-driver/drivers/tty/serial/8250/8250_pericom.c

* Change port type to UPIO_PORT
* Add in pericom_do_startup() because the UPF_MAGIC_MULTIPLIER doesn't 
stick.

When I'm testing baud rates greater than baud_base I'm seeing strange 
things on the scope. Maybe I'm just tired, and it's human error. I 
should be able to get back to it and get it done on Saturday.