linux-kernel - Re: [PATCH v2] fs: proc: store PDE()->data into inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZdQ+0D7n5xCnw5A@infradead.org>
Date:   Thu, 18 Nov 2021 23:23:39 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     akpm@...ux-foundation.org, adobriyan@...il.com,
        gladkov.alexey@...il.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] fs: proc: store PDE()->data into inode->i_private

On Fri, Nov 19, 2021 at 12:11:04PM +0800, Muchun Song wrote:
> +
> +/*
> + * Obtain the private data passed by user through proc_create_data() or
> + * related.
> + */
> +static inline void *pde_data(const struct inode *inode)
> +{
> +	return inode->i_private;
> +}
> +
> +#define PDE_DATA(i)	pde_data(i)

What is the point of pde_data?  If we really think changing to lower
case is worth it (I don't think so, using upper case for getting at
private data is a common idiom in file systems), we can just do that
scripted in one go.