linux-kernel - [mcgrof-next:20211118-sysctl-cleanups-set-04-v2 9/36] fs/notify/dnotify/dnotify.c:36:70: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 09:26:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: [mcgrof-next:20211118-sysctl-cleanups-set-04-v2 9/36]
 fs/notify/dnotify/dnotify.c:36:70: error: macro "register_sysctl_init"
 passed 3 arguments, but takes just 2

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20211118-sysctl-cleanups-set-04-v2
head:   3110d41a56792588bd2f64621080948b0fceb6ab
commit: eff0b1a581f42e5d41c54bb94c590d48774cfbd2 [9/36] dnotify: move dnotify sysctl to dnotify.c
config: m68k-defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=eff0b1a581f42e5d41c54bb94c590d48774cfbd2
        git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
        git fetch --no-tags mcgrof-next 20211118-sysctl-cleanups-set-04-v2
        git checkout eff0b1a581f42e5d41c54bb94c590d48774cfbd2
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/notify/dnotify/dnotify.c: In function 'dnotify_sysctl_init':
>> fs/notify/dnotify/dnotify.c:36:70: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
      36 |         register_sysctl_init("fs", dnotify_sysctls, "dnotify_sysctls");
         |                                                                      ^
   In file included from include/linux/key.h:17,
                    from include/linux/cred.h:13,
                    from include/linux/sched/signal.h:10,
                    from include/linux/rcuwait.h:6,
                    from include/linux/percpu-rwsem.h:7,
                    from include/linux/fs.h:33,
                    from fs/notify/dnotify/dnotify.c:10:
   include/linux/sysctl.h:210: note: macro "register_sysctl_init" defined here
     210 | #define register_sysctl_init(path, table) __register_sysctl_init(path, table, #table)
         | 
>> fs/notify/dnotify/dnotify.c:36:9: error: 'register_sysctl_init' undeclared (first use in this function); did you mean 'register_sysctl_paths'?
      36 |         register_sysctl_init("fs", dnotify_sysctls, "dnotify_sysctls");
         |         ^~~~~~~~~~~~~~~~~~~~
         |         register_sysctl_paths
   fs/notify/dnotify/dnotify.c:36:9: note: each undeclared identifier is reported only once for each function it appears in
   At top level:
   fs/notify/dnotify/dnotify.c:24:25: warning: 'dnotify_sysctls' defined but not used [-Wunused-variable]
      24 | static struct ctl_table dnotify_sysctls[] = {
         |                         ^~~~~~~~~~~~~~~


vim +/register_sysctl_init +36 fs/notify/dnotify/dnotify.c

    21	
    22	int dir_notify_enable __read_mostly = 1;
    23	#ifdef CONFIG_SYSCTL
    24	static struct ctl_table dnotify_sysctls[] = {
    25		{
    26			.procname	= "dir-notify-enable",
    27			.data		= &dir_notify_enable,
    28			.maxlen		= sizeof(int),
    29			.mode		= 0644,
    30			.proc_handler	= proc_dointvec,
    31		},
    32		{}
    33	};
    34	static void __init dnotify_sysctl_init(void)
    35	{
  > 36		register_sysctl_init("fs", dnotify_sysctls, "dnotify_sysctls");
    37	}
    38	#else
    39	#define dnotify_sysctl_init() do { } while (0)
    40	#endif
    41	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (17520 bytes)