[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2df9558ddbc06ac50b7a9aef46445fdf76e7d6b.camel@perches.com>
Date: Fri, 19 Nov 2021 03:20:09 -0800
From: Joe Perches <joe@...ches.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v1 2/3] x86/quirks: Introduce
hpet_dev_print_force_hpet_address() helper
On Fri, 2021-11-19 at 13:00 +0200, Andy Shevchenko wrote:
> Introduce hpet_dev_print_force_hpet_address() helper to unify printing
> forced HPET address. No functional change intended.
This probably reduces object code by a few bytes of text.
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
[]
> @@ -68,6 +68,11 @@ static enum {
> ATI_FORCE_HPET_RESUME,
> } force_hpet_resume_type;
>
> +static void hpet_dev_print_force_hpet_address(struct device *dev)
> +{
> + dev_printk(KERN_DEBUG, dev, "Force enabled HPET at 0x%lx\n", force_hpet_address);
> +}
And this might be better placed up a few lines immediately after
unsigned long force_hpet_address;
and before
enum {
...
} force_hpet_resume_type;
Powered by blists - more mailing lists