linux-kernel - Re: [PATCH bpf v1] unix: fix an issue in unix_shutdown causing the other end read/write failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211119062819.54ff4cdd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 19 Nov 2021 06:28:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiang Wang <jiang.wang@...edance.com>, <cong.wang@...edance.com>
Cc:     Vincent Whitchurch <vincent.whitchurch@...s.com>,
        <bpf@...r.kernel.org>, Casey Schaufler <casey@...aufler-ca.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Eric Dumazet <edumazet@...gle.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Rao Shoaib <Rao.Shoaib@...cle.com>,
        Kuniyuki Iwashima <kuniyu@...zon.co.jp>,
        Jakub Sitnicki <jakub@...udflare.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf v1] unix: fix an issue in unix_shutdown causing the
 other end read/write failures

On Fri, 19 Nov 2021 06:14:19 -0800 Jakub Kicinski wrote:
> On Thu, 11 Nov 2021 15:00:02 +0100 Vincent Whitchurch wrote:
> > On Mon, Oct 04, 2021 at 11:25:28PM +0000, Jiang Wang wrote:  
> > > Commit 94531cfcbe79 ("af_unix: Add unix_stream_proto for sockmap")
> > > sets unix domain socket peer state to TCP_CLOSE
> > > in unix_shutdown. This could happen when the local end is shutdown
> > > but the other end is not. Then the other end will get read or write
> > > failures which is not expected.
> > > 
> > > Fix the issue by setting the local state to shutdown.
> > > 
> > > Fixes: 94531cfcbe79 (af_unix: Add unix_stream_proto for sockmap)
> > > Suggested-by: Cong Wang <cong.wang@...edance.com>
> > > Reported-by: Casey Schaufler <casey@...aufler-ca.com>
> > > Signed-off-by: Jiang Wang <jiang.wang@...edance.com>    
> > 
> > This patch changed the behaviour of read(2) after a shutdown(2) on the
> > local end of a UDS.  Before this patch, reading from a UDS after a local
> > shutdown(SHUT_RDWR) would return the data written or EOF if there is no
> > data, but now it always returns -EINVAL.
> > 
> > For example, the following test program succeeds with "read 16 bytes" on
> > v5.14 but fails with "read: Invalid argument" on v5.15 and mainline:  
> 
> Cong, Jiang, was this regression addressed?

Ah, just saw the patch. What timing.

Thanks Vincent!