linux-kernel - Re: [PATCH] xen/pvh: add missing prototype to header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c654659-b010-791f-78e7-769108934ce2@intel.com>
Date:   Fri, 19 Nov 2021 08:47:49 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        x86@...nel.org, linux-kernel@...r.kernel.org
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] xen/pvh: add missing prototype to header

On 11/19/21 7:39 AM, Juergen Gross wrote:
> The prototype of mem_map_via_hcall() is missing in its header, so add
> it.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> Signed-off-by: Juergen Gross <jgross@...e.com>

$ git describe a43fb7da53007e67ad
v4.20-rc6-5-ga43fb7da5300

Better late than never, I guess.  I wonder what made 0day find this now.

I also guess the one mem_map_via_hcall() call site just used the __weak
definition so it didn't cause problems if there wasn't a declaration in
the header.